Do not launch raw js alert jqueryValidation fails #14854
Conversation
|
(Standard links)
|
|
@eileenmcnaughton Any chance of a quick screenshot so I can be certain which alert you're talking about? |
|
I don't feel quite right about this. Maybe we should just get rid of the |
|
@colemanw I'm happy with any of those options :-) Just removing the alert seems easiest but I feel like in the case of paypal checkout it might be good to display it close to the buttons - if you grab that pr on paypal checkout you'll see how it looks - oh & while you are at it you could dig into why it doesn't work right with webform :-) |
…ages It's really really ugly & as discussed without it a) extensions can still opt to display the errors themselves and b) the inline errors still appear. Note this will have no real affect on existing code - the ugliness of this has been a blocker to getting into front end validation & at this stage only the omnipay extension is trying to work in this space. eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor#128 I think ideally with Omnipay it DOES makes sense to display messages near the checkout button - which might be a future step
eileenmcnaughton
force-pushed
the
validate
branch
from
224b154 to
cd73f9c
Compare
eileenmcnaughton
changed the title
|
@colemanw as discussed - just removing the nasty alerts now |
|
Agreed. The alert doesn't add anything useful, just annoyance. |
Overview
Jquery validation is not enabled much on front end forms but if you DO enable it you get very nasty pure js alert messages. This removes those - after discussion removal makes sense at this stage. You still see the red messages and it's still possible for extensions to capture & render the messages with some jquery foo.
To enable validation on contribution pages in an extension assign
$form->assign('isJsValidate', TRUE);- it will kick in if you try to submit with an invalid emailBefore
Cannot enable Validate without horrendous js alerts
After
Can....
Technical Details
This isn't my ultimate preference - per long discussion here
eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor#128
I think being able to output a summary of messages near, or in place of, the paypal
checkout button makes more sense - open to better options @colemanw
Comments
@colemanw this is what I've been kinda back-ground nagging you about - I had a go - much more detail on the link above