Switch priceset selector to addField method

[mattwire]

Overview

On Manage Event->Amount, ContributionPage->Amount and ContributionPage->Membership switch over the price_set selector to use the addField method. I'd like to make these editable via popup like some of the other fields and this is a first step towards that.

Before

Fields added using hardcoded metadata and old add method.

After

Fields added using schema metadata and addField method.

Technical Details

Switch to metadata methods like we've done elsewhere.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I tried changing price set on the contribution page fees tab & member tab along with the civievent fees tab & it all worked fine.

I note that I hit js errors on the event one until I disabled civivolunteer but I know @ginkgomzd is planning on dropping a civivolunteer release soon & I suspect I'm running the released version not the soon-to-be released version - so I think these are unrelated & pre-existing errors