[REF] [Export] Simplify setting of address strings #14835
Conversation
|
(Standard links)
|
|
Hmm, I don't quite understand how this simplifies things. It's an additional param to |
|
@colemanw well $exportParams is ALREADY the formValues array - so we are renaming it to be more accurate. In addition we are moving it out of random place to being analysed at the start so we can stop passing the array around the exportComponents function. I'd rather split it out better but this gets it out of the 'deep down' part of the function |
|
test this please |
1 similar comment
|
test this please |
| * - addresee_greeting | ||
| * - addressee_other | ||
| */ | ||
| public function __construct($exportMode, $requestedFields, $queryOperator, $isMergeSameHousehold = FALSE, $isPostalableOnly = FALSE, $isMergeSameAddress = FALSE, $formValues = []) { |
There was a problem hiding this comment.
We haven't adopted an official documentation standard for arrays, but I like the looks of this one: https://stackoverflow.com/a/51032174/2918050
|
Ok I'll take your word for it. I left one comment about the formatting of the docblock, but other than that it looks good. |
Overview
Minor refactor of export strings (this is well tested code)
Before
Less readable
After
More readable
Technical Details
Comments