Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique names and unique title for recurrings. #14820

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 14, 2019

Overview

Adds key unique_title to the entity definition schema

Before

Only possible to determine one 'title' field

After

'title' & 'unique_title' can both be defined - the latter is for situations where multiple entities may be involved (e.g advanced search) and disambiguation is needed

Technical Details

Per discussion https://github.com/civicrm/civicrm-core/pull/14737/files#r300889057
we hace a need sometimes to display context dependent titles & context independent titles.

This adds unique_title for the purpose

Comments

Per
discussion https://github.com/civicrm/civicrm-core/pull/14737/files#r300889057
we hace a need sometimes to display context dependent titles & context independent titles.

This adds unique_title for the purpose
@civibot
Copy link

civibot bot commented Jul 14, 2019

(Standard links)

@civibot civibot bot added the master label Jul 14, 2019
@colemanw
Copy link
Member

colemanw commented Jul 14, 2019

@eileenmcnaughton what's the reason for also adding unique names here?

As you know I'm not a big fan of unique names, preferring nested arrays/objects where the entity name is explicit and the fields specific to that entity are contained within. That's how afform works.

Unique titles actually make more sense to me than unique names (although we could do the same thing with nesting in fieldsets in the UI to give context).

@eileenmcnaughton
Copy link
Contributor Author

@colemanw for advanced search... pretty much the reason for all the unique names - part of the linked pr

@seamuslee001
Copy link
Contributor

This looks fine to me and is how we are moving with field conversions for datepicker. Merging

@seamuslee001 seamuslee001 merged commit 0a12108 into civicrm:master Jul 14, 2019
@seamuslee001 seamuslee001 deleted the recur branch July 14, 2019 21:32
@mattwire
Copy link
Contributor

This has the potential to add a LOT of additional strings just so we can have the entity name in the title - surely there's a better way than this? @bgm any thoughts on the translation side?

@eileenmcnaughton
Copy link
Contributor Author

@mattwire they will only get added as needed & pretty much the only strings that get added are being moved not genuinely added - half a dozen ATM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants