Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Export] Stop passing export params to the merge function #14819

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup - previous PR added a unit test for this

Before

Parameter needlessly passed

After

Parameter not passed

Technical Details

We have a string which does or doesn't have merge tokens in it - we don't need to determine this

Comments

We have a string which does or doesn't have merge tokens in it - we don't need  to determine this
@civibot
Copy link

civibot bot commented Jul 14, 2019

(Standard links)

@civibot civibot bot added the master label Jul 14, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw another littlie

@colemanw
Copy link
Member

Code looks good & tests pass.

@colemanw colemanw merged commit 46e6a0e into civicrm:master Jul 14, 2019
@colemanw colemanw deleted the export_up branch July 14, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants