Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Export] clean up incorporation of order by & group by into ExportProcessor #14811

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Consolidate all the code required to build the query into one function

Before

All over the place :-)

After

In build Query

Technical Details

Part of larger code cleanup

Comments

@civibot
Copy link

civibot bot commented Jul 12, 2019

(Standard links)

@civibot civibot bot added the master label Jul 12, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

Test failure unrelated.
Merging based on code review & passing tests.

@colemanw colemanw merged commit 75a580b into civicrm:master Jul 12, 2019
@colemanw colemanw deleted the ex1 branch July 12, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants