Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Export] Further cleanup - construct sql more concisely #14808

Merged
merged 2 commits into from
Jul 12, 2019
Merged

[REF] [Export] Further cleanup - construct sql more concisely #14808

merged 2 commits into from
Jul 12, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 12, 2019 •
edited
Loading

Overview

Code cleanup

Before

SQL compilation 'distributed'

After

SQL compilation consolidated

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 12, 2019

(Standard links)

@civibot civibot bot added the master label Jul 12, 2019
@eileenmcnaughton eileenmcnaughton changed the title Export sql [REF] [Export] Further cleanup - construct sql more concisely Jul 12, 2019
@colemanw
Copy link
Member

Adding MOP based on code review

@eileenmcnaughton eileenmcnaughton merged commit 28a5740 into civicrm:master Jul 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the export_sql branch July 12, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw