Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [EXPORT] Alter CRM_Export_BAO_Export::exportComponents #14800

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

colemanw
Copy link
Member

Overview

Refactors the function CRM_Export_BAO_Export::exportComponents to accept fields in a standard format, rather than the crazy thing we get back from Quickform. This allows the new ExportUi extension to work.

Before

Field format converted from qf to standard array inside function.

After

Field format converted from qf to standard array outside function.

@civibot
Copy link

civibot bot commented Jul 11, 2019

(Standard links)

@civibot civibot bot added the master label Jul 11, 2019
@eileenmcnaughton
Copy link
Contributor

Code changes are as expected /planned/discussed - let's see what Jenkins says

Note we expect to do more r-run testing once this is all settled

@eileenmcnaughton
Copy link
Contributor

Relevant tests have passed - I'm going to merge this now as we have some conflict issues that need resolving once this is merged (I'll check there was no test fall out today just in case)

@eileenmcnaughton eileenmcnaughton merged commit b4a39e3 into civicrm:master Jul 12, 2019
@eileenmcnaughton eileenmcnaughton deleted the mapperKeys branch July 12, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants