Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORT] Minor fixes to the export form #14785

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 10, 2019

Overview

Couple of minor fixes to the export form:

  1. Only show enabled contact types (only relevant if e.g. Households are disabled)
  2. Correctly show list of relationship types for a given contact type.

Before

Screen Shot 2019-07-11 at 8 47 17 AM

After

Screen Shot 2019-07-11 at 8 48 34 AM

Comments

This is mostly to support the new ExportUi extension. This does cause the existing export form to burp up an e-notice if you disable a contact type like Households or Organizations, but I I'm not sure that's a big problem, as that scenario isn't actually supported in the UI and it'll be replaced by the extension soon (which handles it fine with no e-notice).

@civibot
Copy link

civibot bot commented Jul 10, 2019

(Standard links)

@civibot civibot bot added the master label Jul 10, 2019
@colemanw colemanw changed the title Minor fixes to the export form [EXPORT] Minor fixes to the export form Jul 10, 2019
@eileenmcnaughton
Copy link
Contributor

this makes sense in the export UI (screenshots added) - just checking import & search builder

@eileenmcnaughton
Copy link
Contributor

OK I checked import & the extra relationships don't make sense there either & search builder seems unaffected.

Relationships like Child -> Parent still show twice but we no longer see 'Head of Household is' - which only makes sense for Households. I think I hit confusion on this in the past so it's good to change. Merging

@eileenmcnaughton eileenmcnaughton merged commit e40730d into civicrm:master Jul 10, 2019
@eileenmcnaughton eileenmcnaughton deleted the contactTypes branch July 10, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants