dev/drupal#75 Drupal8: fix call to languageNegotiationURL() when called from cv

[mlutfy]

Overview

Silly/obvious coding error was causing cv to fail.

https://lab.civicrm.org/dev/drupal/issues/75

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

I've tested this, it fixes the problem. I also reviewed the code and it makes a lot of sense. In theory it could be combined with the if statement above it, but I think it's more readable this way, since the two if statements are covering two different use cases. I'm good with this having a "merge-on-pass" - and since I'm guessing we don't have D8 test coverage yet, that seems like a given.

[eileenmcnaughton]

dang I merged to master but it needed to be the rc

[eileenmcnaughton]

^^ is 5.15 & 5.16 ports - @mlutfy can you check & merge them?

[cullyRSG]

(I'm super new at this, go gentle please!)
Looks like this was reverted back somehow. I was getting the same error when calling cv and was able to fix it and run cv without issue by implementing this. Seems as though this never got rolled out. The spot in Drupal8.php is line 658..

[demeritcowboy]

@cullyRSG What cv command are you using since the spot you've linked to is actually a different code block than the one in this PR. In the spot you've linked it's about returning the language not the url. Maybe make a new ticket at https://lab.civicrm.org/dev/drupal/-/issues/new and say what cv command you're using. If drupal isn't bootstrapped yet it wouldn't know what else to return other than null (maybe en_US?).