Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] initial extraction of loading saved mapping to qf format #14767

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 9, 2019

Overview

Minor extraction

Before

Less readable

After

Janky but in the right direction. The phoneType & imProvider stuff looks nasty but not more nasty

Technical Details

Comments

@colemanw

Janky but in the right direction. The phoneType & imProvider stuff looks nasty but not more nasty
@civibot
Copy link

civibot bot commented Jul 9, 2019

(Standard links)

@civibot civibot bot added the master label Jul 9, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

colemanw commented Jul 9, 2019

That's quite an argument list! Are you sure all of those params are necessary?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw no - I don't think they are - but I'm a strong believer you do the extraction as clean as possible and then start to clean up the params - otherwise the risk of mistakes is a lot higher

@eileenmcnaughton
Copy link
Contributor Author

@colemanw this has passed now

@colemanw colemanw merged commit d6a5143 into civicrm:master Jul 10, 2019
@colemanw colemanw deleted the export_2 branch July 10, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants