Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enotice on formatting credit card details #14750

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 7, 2019

Overview

Enotice fix

Before

Screen Shot 2019-07-08 at 11 51 35 AM

After

Gone

Technical Details

To be honest I can't' quite see why it gets past the existing if (in_array('credit_card_type', array_keys($params))) { to cause this enotice but if (!empty($params['credit_card_type'])) { is also much more consistent with the style in our codebase and we would not want to try to resolve 'set but empty'

Comments

@civibot
Copy link

civibot bot commented Jul 7, 2019

(Standard links)

@civibot civibot bot added the master label Jul 7, 2019
@eileenmcnaughton eileenmcnaughton changed the title Fix entoice on formatting credit card details Fix enotice on formatting credit card details Jul 7, 2019
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

@colemanw can you merge?

@monishdeb
Copy link
Member

Its a simple and required change. Merging now.

@monishdeb monishdeb merged commit 45486b9 into civicrm:master Jul 10, 2019
@eileenmcnaughton eileenmcnaughton deleted the pay_notice branch July 10, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants