dev/core#1081 fix for error on contribution detail when using custom data order by without select

[eileenmcnaughton]

Overview

Fixes fatal error on contribution detail report when sorting by a custom field that is not selected

Before

Fatal error

After

Report succeeds & is tested

Technical Details

I swept up 4 reports in the test (using an existing dataProvider function) - the contribution summary report failed in Full Group By mode so I added a disable->re-enable to address that

Comments

https://lab.civicrm.org/dev/core/issues/1081

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@kcristiano fyi since this is against the rc

[kcristiano]

@eileenmcnaughton I did a quick r-run after applying the patch on top of 5.16-RC.

I did not see any breakage on the Contribution details report (as that was in the issue). However, I don't see any errors without the patch either.

In any case I'd rather have this in than out and have more time for testing.

[eileenmcnaughton]

@kcristiano ok - merging based on that - this does add tests that cover the breakage. Unrelated test fail