[REF] un-extract createProportionalFinancialEntities

[eileenmcnaughton]

Overview

Separate code that is being shared in an unhelpful way back into it's calling function. This unextraction it preliminary to different cleanups but not unsharing this code makes that possible. I have duplicated the contents of the function as it is still used by change payment instrument and the goal is to fix adding payments without touching that

Before

Less clean-upable

After

More cleanupable

Technical Details

This is one of those places where, unituitively, I think undoing an extraction makes sense.

The code for allocating monies to financial items is shared with the change payment instrument functionality
but fundamentally these are different processes and sharing the code is making it less rather than more readable.

My goal is to pull back all the code that handles processing financials off a payment back into Payment.create
and to clean it up from there

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@colemanw can you merge this - can't believe I'm advocating return to copy & paste :-)