Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Simple function extraction for buildMappingForm #14741

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[REF] Simple function extraction for buildMappingForm #14741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 55 additions & 45 deletions CRM/Core/BAO/Mapping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ public static function buildMappingForm(&$form, $mappingType, $mappingId, $colum

$hasLocationTypes = [];
$hasRelationTypes = [];
$fields = [];

//get the saved mapping details

Expand Down Expand Up @@ -346,49 +345,7 @@ public static function buildMappingForm(&$form, $mappingType, $mappingId, $colum
);
}

$contactType = ['Individual', 'Household', 'Organization'];
foreach ($contactType as $value) {
if ($mappingType == 'Search Builder') {
// get multiple custom group fields in this context
$contactFields = CRM_Contact_BAO_Contact::exportableFields($value, FALSE, FALSE, FALSE, TRUE);
}
else {
$contactFields = CRM_Contact_BAO_Contact::exportableFields($value, FALSE, TRUE);
}
$contactFields = array_merge($contactFields, CRM_Contact_BAO_Query_Hook::singleton()->getFields());

// exclude the address options disabled in the Address Settings
$fields[$value] = CRM_Core_BAO_Address::validateAddressOptions($contactFields);
ksort($fields[$value]);
if ($mappingType == 'Export') {
$relationships = [];
$relationshipTypes = CRM_Contact_BAO_Relationship::getContactRelationshipType(NULL, NULL, NULL, $value, TRUE);
asort($relationshipTypes);

foreach ($relationshipTypes as $key => $var) {
list($type) = explode('_', $key);

$relationships[$key]['title'] = $var;
$relationships[$key]['headerPattern'] = '/' . preg_quote($var, '/') . '/';
$relationships[$key]['export'] = TRUE;
$relationships[$key]['relationship_type_id'] = $type;
$relationships[$key]['related'] = TRUE;
$relationships[$key]['hasRelationType'] = 1;
}

if (!empty($relationships)) {
$fields[$value] = array_merge($fields[$value],
['related' => ['title' => ts('- related contact info -')]],
$relationships
);
}
}
}

//get the current employer for mapping.
if ($mappingType == 'Export') {
$fields['Individual']['current_employer_id']['title'] = ts('Current Employer ID');
}
$fields = self::getBasicFields($mappingType);

// add component fields
$compArray = [];
Expand Down Expand Up @@ -589,7 +546,7 @@ public static function buildMappingForm(&$form, $mappingType, $mappingId, $colum
if ($key) {
// sort everything BUT the contactType which is sorted separately by
// an initial commit of CRM-13278 (check ksort above)
if (!in_array($key, $contactType)) {
if (!in_array($key, ['Individual', 'Household', 'Organization'])) {
asort($mapperFields[$key]);
}
$sel2[$key] = ['' => ts('- select field -')] + $mapperFields[$key];
Expand Down Expand Up @@ -962,6 +919,59 @@ public static function buildMappingForm(&$form, $mappingType, $mappingId, $colum
$form->setDefaultAction('refresh');
}

/**
* @param string $mappingType
* @return array
*/
public static function getBasicFields($mappingType) {
$contactTypes = ['Individual', 'Household', 'Organization'];
$fields = [];
foreach ($contactTypes as $contactType) {
if ($mappingType == 'Search Builder') {
// Get multiple custom group fields in this context
$contactFields = CRM_Contact_BAO_Contact::exportableFields($contactType, FALSE, FALSE, FALSE, TRUE);
}
else {
$contactFields = CRM_Contact_BAO_Contact::exportableFields($contactType, FALSE, TRUE);
}
$contactFields = array_merge($contactFields, CRM_Contact_BAO_Query_Hook::singleton()->getFields());

// Exclude the address options disabled in the Address Settings
$fields[$contactType] = CRM_Core_BAO_Address::validateAddressOptions($contactFields);
ksort($fields[$contactType]);
if ($mappingType == 'Export') {
$relationships = [];
$relationshipTypes = CRM_Contact_BAO_Relationship::getContactRelationshipType(NULL, NULL, NULL, $contactType, TRUE);
asort($relationshipTypes);

foreach ($relationshipTypes as $key => $var) {
list($type) = explode('_', $key);

$relationships[$key]['title'] = $var;
$relationships[$key]['headerPattern'] = '/' . preg_quote($var, '/') . '/';
$relationships[$key]['export'] = TRUE;
$relationships[$key]['relationship_type_id'] = $type;
$relationships[$key]['related'] = TRUE;
$relationships[$key]['hasRelationType'] = 1;
}

if (!empty($relationships)) {
$fields[$contactType] = array_merge($fields[$contactType],
['related' => ['title' => ts('- related contact info -')]],
$relationships
);
}
}
}

// Get the current employer for mapping.
if ($mappingType == 'Export') {
$fields['Individual']['current_employer_id']['title'] = ts('Current Employer ID');
}

return $fields;
}

/**
* Function returns all custom fields with group title and
* field label
Expand Down