Remove use of deprecated path in function CRM_Event_BAO_Event::checkPermission()

[mattwire]

Overview

Switch from deprecated to non deprecated function.

Before

Throws PHP notice and calls getAllPermissions()

After

Calls getAllPermissions() directly.

Technical Details

Per previous work, checkPermissions() should only be called for a specific event ID.

Comments

This permission check seems to hide the "scheduled reminders" tab if you are not an administrator or if you don't have edit permissions on any events. That doesn't really make sense to me - as I don't really see why it should be treated differently to other manageevent tabs? @lcdservices @alifrumin Any thoughts?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

@mattwire I actually think scheduled reminders should have their own permission. But absent that -- I agree, if you can create an event, you should be able to schedule reminders for it.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

OK - I stepped through this in a debugger & agree this is switching to a non-deprecated method to do the same thing