[REF] final cleanup - call bulkCreate from migrate_utils #14728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This needs rebuild |
eileenmcnaughton
force-pushed
the
last_icing
branch
2 times, most recently
from
509c40a to
c851189
Compare
pradpnayak
reviewed
Jul 5, 2019
| @@ -137,7 +137,7 @@ public function basicXmlTestCases() { | |||
| // CustomGroup params | |||
| array( | |||
| 'extends' => 'Activity', | |||
| 'extends_entity_column_value' => array(array_search('Meeting', CRM_Core_PseudoConstant::activityType())), | |||
| 'extends_entity_column_value' => [1], | |||
There was a problem hiding this comment.
yes - because it's in the dataprovider (I guess) this test won't run in isolation if it is accessing the DB
eileenmcnaughton
force-pushed
the
last_icing
branch
from
c851189 to
54cbbe2
Compare
This has a test CRM_Utils_Migrate_ImportExportTest although I had trouble running it without switching to some hard-coding (at least in isolation). This switches the existing bulk create action over to use bulkCreate
eileenmcnaughton
force-pushed
the
last_icing
branch
from
54cbbe2 to
ead0c08
Compare
|
Merging based on code review & passing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a final cleanup to call rather than replicate bulkCreate from migrate utils
Before
Lots of single use code
After
DRY
Technical Details
Good testing on this function - rest of commits will be rebased out of this before it is up for final review - but I had to tweak the test to run in isolation
Comments