Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] simple extraction of prepareCreateParams #14726

Merged
merged 1 commit into from
Jul 4, 2019
Merged

[REF] simple extraction of prepareCreateParams #14726

merged 1 commit into from
Jul 4, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Simple function extraction

Before

Less readable

After

More readable

Technical Details

Simple extraction

Comments

@civibot
Copy link

civibot bot commented Jul 3, 2019

(Standard links)

@civibot civibot bot added the master label Jul 3, 2019
@pradpnayak
Copy link
Contributor

Did a QA on current state of code.

Testcase: Added/Updated custom field via UI and api.
Result: Custom field was added/updated.

Safe to merge!

@mattwire
Copy link
Contributor

mattwire commented Jul 4, 2019

Merging based on @pradpnayak review

@mattwire mattwire merged commit 6771287 into civicrm:master Jul 4, 2019
@eileenmcnaughton eileenmcnaughton deleted the cust_field_5 branch July 4, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @pradpnayak @mattwire