[REF] extract portion that creates the custom field record #14725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cust_field4
branch
from
3a2fd0a to
0da74fc
Compare
|
This need rebasing as well |
eileenmcnaughton
force-pushed
the
cust_field4
branch
from
0da74fc to
f45a42b
Compare
|
thanks - this is now rebased |
eileenmcnaughton
commented
Jul 4, 2019
|
|
||
| $triggerRebuild = CRM_Utils_Array::value('triggerRebuild', $params, TRUE); | ||
| //create/drop the index when we toggle the is_searchable flag | ||
| $customField = self::createCustomFieldRecord($params); | ||
| $op = empty($params['id']) ? 'add' : 'modify'; |
There was a problem hiding this comment.
Actually @pradpnayak the net effect here is to set the op AFTER the pre hook has been called. I'm now on the fence about that - I guess it's a good thing to set afterwards even though other BAO don't but are also kinda inconsistent.
|
I don't have a strong opinion on that. I think this is better in than out so adding MOP. |
|
merged per mop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code extraction
Before
Less readable
After
More readable
Technical Details
Note this incorporates #14705 & extends it (which in turn is a superset of #14724 - this allows a reviewer to choose the size of 'chunk' to review)
Comments
Towards #14694