Fix public URL link with hashed URLs in mailing browse screen #14722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
JKingsnorth
force-pushed
the
fix-public-url-link-in-browse
branch
from
98b1a59 to
9ed1c2e
Compare
|
@JKingsnorth I think #14508 made it into the 5.16 rc didn't it - I switched the base |
|
This makes sense looking through it as & there is no change if hash is not defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up from #14508
If 'hashed mailing URLs' setting is enabled then the 'Public view' links in the mailing browser page do not work correctly. They do not use the 'hash' when required.
Now they do: (sorry for the dodgy screenshot)
Technical Details
Added a replacement pattern to the 'actions' selector, so that the mailing ID or the hash is used when appropriate.