(WIP) Move configAndLogDir/templateCompileDir from "Runtime" to "Paths" (compat variant) #14719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o "Paths" (prioritize compat) This slightly changes the computation of the private log and compilation directories so that: * The definition appears more declarative. * The default is computed on-demand (i.e. later in the process). * The values can be overriden more intuitively. Before ------ The properties `$config->configAndLogDir` and `$config->templateCompileDir` are computed as part of a procedural initialization step in `CRM_Core_Config_Runtime`. After ----- The properties `$config->configAndLogDir` and `$config->templateCompileDir` are computed on-demand by `Civi\Core\Paths`. The values of these properties may: * Be computed automatically in a way that matches the previous output (i.e. `configAndLogDir`=~`CIVICRM_TEMPLATE_COMPILEDIR/../configAndLog`; `templateCompileDir`=~`CIVICRM_TEMPLATE_COMPILEDIR`). * Be customized as a pair (by setting `civicrm.private`) * Be customized individually (by setting `civicrm.logs` or `civicrm.compile`).
|
(Standard links)
|
|
jenkins, test this please |
|
Closing in favor of #14718. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Description TBD. Note: This is the variant which prioritizes more precise continuity with the existing behavior.)