Grab contribution status id from database

[pradpnayak]

Overview

Grab contribution status id from database

Before

Hard coded to 1

After

Used CRM_Core_PseudoConstant::getKey() function to get completed status id

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree this is more correct & it's a straight forward pattern @pradpnayak is working on swapping out (presumably he finally hit the Db where we can't get away with our myriad hard-codings :-)