Deprecate some deprecated address functions: defaultCurrencySymbol

[eileenmcnaughton]

Overview

Reviewer's partial of #14576

Before

Deprecated calls to $config->defaultCurrencySymbol

After

Calls to CRM_Core_BAO_Country::defaultCurrencySymbol()

Technical Details

This is pretty confusing - $config->defaultCurrencySymbol calls

  'defaultCurrencySymbol' => ['callback', 'CRM_Core_BAO_Country', 'getDefaultCurrencySymbol'],

due to the magic merge - so changing $config->defaultCurrencySymbol to CRM_Core_BAO_Country::defaultCurrencySymbol() does the same thing (and probably I would have rathered keep the scope of one PR to just doing those swaps).

However that function https://github.com/civicrm/civicrm-core/compare/master...eileenmcnaughton:matt?expand=1#diff-cad2bac1dfa829957024f6c1da207254L163 was then calling $config->defaultCurrencySymbol(Civi::settings()->get('defaultCurrency')); which in turn calls CRM_Core_BAO_Country::defaultCurrencySymbol($defaultCurrency); so this cuts the extra function out of that loop & deprecates it

Comments

I didn't feel able to review changes to multiple functions in one hit so pulled out one change to review & merge in the first instance from the larger PR

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

merge on pass as a reviewer's commit

[eileenmcnaughton]

test this please