[REF] transform the setting of defaults in CustomField::create to be like (some) other entities #14671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@eileenmcnaughton can you rebase this please |
eileenmcnaughton
force-pushed
the
cust_field
branch
from
06c753d to
6d65817
Compare
eileenmcnaughton
force-pushed
the
cust_field
branch
from
6d65817 to
0d16542
Compare
|
@eileenmcnaughton what happened? |
…like (some) other entities This patter (massaging the params & then copying) is more consistent. PR also moves creating the transaction to the start of the fn I am cleaning up towards adding a bulk function that can be utilised by api v4 to create multiple fields with some efficiency on sql statements (which matters when adding 2 or more fields to a large table)
|
I think I mis-pushed it to be empty & it auto-closed |
|
it's back! |
|
@colemanw passing now |
colemanw
reviewed
Jul 1, 2019
| //CRM-15792 - Custom field gets disabled if is_active not set | ||
| // this would ideally be a mysql default. | ||
| 'is_active' => TRUE, | ||
| 'is_view' => FALSE, |
There was a problem hiding this comment.
Why wouldn't all of these be mysql defaults?
There was a problem hiding this comment.
Yeah beats me - but I wasn't going that far in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup only
Before
Less consistent / readable
After
More consistent / readable
Technical Details
This pattern (massaging the params & then copying) is more consistent. PR also moves creating the transaction to the start of the fn
I am cleaning up towards adding a bulk function that can be utilised by api v4 to create multiple fields with some efficiency on
sql statements (which matters when adding 2 or more fields to a large table)
Comments