Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-core#1079: Improper character encoding breaks xml processor #14654

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

monishdeb
Copy link
Member

Overview

When printing a case, if the contact name has an ampersand (&) it breaks loadXML due to improper encoding, resulting in the activity listing not displaying.
Steps to replicate:

  1. Create a Case where client name should have & character
  2. Go to 'Manage Case'
  3. Click 'Print Report'

Before

There are no activities on the preview screen.

After

Activities are listed on the preview screen

Comments

ping @colemanw @lcdservices

@civibot
Copy link

civibot bot commented Jun 27, 2019

(Standard links)

@civibot civibot bot added the master label Jun 27, 2019
@lcdservices
Copy link
Contributor

Tested and confirmed. Activities are listed when a client name has an ampersand.

@eileenmcnaughton
Copy link
Contributor

The level of testing here seems appropriate to the change given the bug was replicable. In addition the change adds good practice (use of escape at the tpl layer)

@eileenmcnaughton eileenmcnaughton merged commit 105d4d7 into civicrm:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants