Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove columnName field #14651

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes an unnecessary parameter

Before

Parameter in use

After

Parameter gone

Technical Details

This field always holds the same information as ['column_name']. It was introduced
before https://github.com/civicrm/civicrm-core/pull/1206/files which removed some of it's
use but not the variable. There is test coverage on passing in column_name
in testCreateCustomFieldColumnName

Comments

This field always holds the same information as ['column_name']. It was introduced
before https://github.com/civicrm/civicrm-core/pull/1206/files which removed some of it's
use but not the variable. There is test coverage on passing in column_name
in testCreateCustomFieldColumnName
@civibot
Copy link

civibot bot commented Jun 27, 2019

(Standard links)

@civibot civibot bot added the master label Jun 27, 2019
@colemanw
Copy link
Member

Code looks like straightforward cleanup and tests pass.

@colemanw colemanw merged commit d354311 into civicrm:master Jun 28, 2019
@colemanw colemanw deleted the cust_field_2 branch June 28, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants