Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused spec function #14646

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

colemanw
Copy link
Member

Overview

This spec function was incorrectly named (spec functions should start with an underscore) and therefore not actually doing anything. No one was complaining before, so we probably don't need it. This PR is my vote to remove it.

Before

Spec function not actually used.

After

Spec function gone.

Comments

IMO documenting an option by calling it a field is not a great practice which made me less inclined to keep the function around.

@civibot
Copy link

civibot bot commented Jun 27, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Agree removing is safer than fixing & it IS broken

@eileenmcnaughton eileenmcnaughton merged commit c842283 into civicrm:master Jun 27, 2019
@eileenmcnaughton eileenmcnaughton deleted the pledgeSpec branch June 27, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants