Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This spec function was incorrectly named (spec functions should start with an underscore) and therefore not actually doing anything. No one was complaining before, so we probably don't need it. This PR is my vote to remove it.
Before
Spec function not actually used.
After
Spec function gone.
Comments
IMO documenting an option by calling it a field is not a great practice which made me less inclined to keep the function around.