Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few places where pass by reference is used but does not need to be #14643

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup

Before

Parameters passed by reference unnecessarily

After

Parameters not passed by reference

Technical Details

Digging into this code I find us using a practice that we stopped 6+ years ago - ie. passing parameters as a reference when the receiving function does not alter them. This was once thought to be more performance & php4 friendly....

Comments

@civibot
Copy link

civibot bot commented Jun 27, 2019

(Standard links)

@civibot civibot bot added the master label Jun 27, 2019
@colemanw
Copy link
Member

Gotta love php4 holdovers.

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 3de1ad2 into civicrm:master Jun 27, 2019
@eileenmcnaughton eileenmcnaughton deleted the schemah branch June 27, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants