Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add in unit test attempting to demonstrate issue caused by dev… #14637

Merged

Conversation

seamuslee001
Copy link
Contributor

…/core#1069

Overview

This updates our current unit test to include a situation where we are using the logged in contact's email address as the from email address by passing a numerical from_email_address param to the form submission

Before

No Test

After

Test

ping @yashodha @eileenmcnaughton is there anything else we need to be testing here? this is passing for me locally, i'm trying to nail down the exact steps to replicate

@civibot
Copy link

civibot bot commented Jun 25, 2019

(Standard links)

@civibot civibot bot added the master label Jun 25, 2019
@eileenmcnaughton
Copy link
Contributor

Extends test cover

@eileenmcnaughton eileenmcnaughton merged commit cf960ea into civicrm:master Jun 27, 2019
@eileenmcnaughton eileenmcnaughton deleted the unit_test_dev_core_1069 branch June 27, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants