Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to receive_date convert to datepicker - update test #14627

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a test that is no longer testing the right format

Before

Testing for old format - https://test.civicrm.org/job/CiviCRM-Core-PR/27239/testReport/junit/(root)/CRM_Contact_BAO_SavedSearchTest/testRelativeDateValues/ shows this failing

After

contribution_date should no longer be handled in this way - altering the test

Technical Details

Comments

@seamuslee001

@civibot
Copy link

civibot bot commented Jun 24, 2019

(Standard links)

@civibot civibot bot added the master label Jun 24, 2019
@colemanw
Copy link
Member

This seems to beg the question, "why was a faulty test passing before?" Is the test functional?

@eileenmcnaughton
Copy link
Contributor Author

@colemanw don't ask questions you don't want to know....

I think it starts failing when you do additional cleanup of no-longer-needed code

@seamuslee001 seamuslee001 merged commit 6bf455b into civicrm:master Jun 24, 2019
@seamuslee001 seamuslee001 deleted the cont_date branch June 24, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants