EntityPageTrait: Set logged in contact ID as default if one is not specified - this allows permission checks etc. to work properly.

[mattwire]

Overview

Currently the entitypagetrait is only in use by CRM_Contact_Page_View_Relationship. However the plan is to extend it to other pages too. This PR updates it to get the logged in contact ID if none is passed in - so it can be used on non-contact forms (eg. event lists).

Before

Requires a contact ID to be passed in via $_GET

After

Uses a contact ID passed in via $_GET, if not set gets the logged in contact ID.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@eileenmcnaughton @colemanw This trait is currently only used on the relationship form so this change is effectively NFC at this point as the contactID is passed reliably by the relationship form. But I'd like to extend it's use to other pages where we can't be sure the contactID will be passed reliably.

[eileenmcnaughton]

@mattwire this is mostly for backend forms isn't it? I'm kinda ok as it's not in use much & it's a page not a form but normally back office you are acting on someone else's record

[mattwire]

@eileenmcnaughton Yes mostly for backend forms. If you're working on someone else's record then you should be explicitly passing in the contactID. There are various examples (eg. events pages) where you are not working with a contact at all, but the pages use the contactID to do permissions checks.

[eileenmcnaughton]

ok