REF Simple cleanup of tabset code for contributionpages

[mattwire]

Overview

Just simplify the code a little bit (per Event TabHeader.php). There is a lot of further scope for consolidating the two classes.

Before

Duplicate values in array

After

Shared values added to each array element

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@mattwire other than the style warnings this is fine - ie. it causes no regression & makes sense. I did wonder if we even need to set those falsey-defaults and I tried just removing the + $defaults and got no regression or enotices so we could possibly also leave off. Either way if you can sell jenkins on this I'm good with it.

[mattwire]

@eileenmcnaughton Do you want to merge?