Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of 'Manage Event' title #14614

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

mattwire
Copy link
Contributor

Overview

Switch to using standard form method for assigning title so we have access to the title during postprocess.

Before

Title not set on form object during postprocess.

After

Title set on form object during postprocess and used in the "Saved" message:
image

Technical Details

Switch from CRM_Utils_System::setTitle() to $this->setTitle(). Assign the title to the form in CRM_Core_Form::setTitle() method as we've done with other extractions.

Comments

@alifrumin @lcdservices Either of you in a position to test from a UI POV?

@civibot
Copy link

civibot bot commented Jun 23, 2019

(Standard links)

@alifrumin
Copy link
Contributor

alifrumin commented Jun 24, 2019

Hey @mattwire,

I took a spin of this on the jenkins build. It looks good to me.

Specifically I created a new event (which worked as expected)
On save of the new event, the 'saved' status message included the title of the event as described in the After section above.

CRM/Core/Form.php Outdated Show resolved Hide resolved
@mattwire mattwire force-pushed the manageevent_title branch from 2fc386d to 648deec Compare July 4, 2019 13:50
@eileenmcnaughton
Copy link
Contributor

Ok - this addresses the reviewer comments - merging

@eileenmcnaughton eileenmcnaughton merged commit ac68453 into civicrm:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants