Follow up fix on start as a url parameter #14611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| if (!empty($highReceiveDate)) { | ||
| $this->_formValues['receive_date_high'] = date('Y-m-d H:i:s', strtotime($highReceiveDate)); | ||
| CRM_Core_Error::deprecatedFunctionWarning('pass receive_date_high not end'); | ||
| } |
There was a problem hiding this comment.
@eileenmcnaughton do we need to port the relative_handling as well?
There was a problem hiding this comment.
@seamuslee001 so I think the relative date handling is not handling the relative date in the url but ensuring it is zero'd if the high or low are set - which I think IS handled in the generic handling
|
@eileenmcnaughton this looks fine to me once my question is resolved, however i'm still not seeing any sign the values are actually being passed to the query |
|
test fails unrelated (we can probably spare ourselves re-running them as I think this is ready to merge?) |
|
@eileenmcnaughton yeh ok to merge. I can re-rest in RC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-instates report for 'start' & 'end' in search urls - but deprecates them
Before
start=2018-01-01 wasn't working on contribution search
After
works but gives a deprecation notice
Technical Details
Moving to stdised urls but should still support this for a while - as it's used from core
Comments
@seamuslee001