Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] do not pass by reference to store & create functions #14598

Merged
merged 1 commit into from
Jun 22, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor code cleanup

Before

Deprecate code practice used

After

Preferred practice used

Technical Details

After checking the code these are unchanged & not using pass-by-reference unecessarily is better practice

Comments

After checking the code these are unchanged & not using pass-by-reference unecessarily is better practice
@civibot
Copy link

civibot bot commented Jun 22, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

This looks sensible adding MOP

@seamuslee001 seamuslee001 merged commit 2b6d3c2 into civicrm:master Jun 22, 2019
@seamuslee001 seamuslee001 deleted the amp branch June 22, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants