Update Owner Membership ID label in reports to be Primary Membership …

[seamuslee001]

…to be more consistant with rest of system

Overview

This changes the label in membership reports from Owner Membership ID to be Primary Membership as per discussion on #14530

Before

Unusual label Owner Membership ID used

After

More standardised label Primary Membership used

ping @jusfreeman @MegaphoneJon @agh1 @eileenmcnaughton @yashodha i tend to agree with Andrew that Primary Membership will suffice especially given the other places where we use the term Primary rather than Owner Membership or similar

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jusfreeman]

@seamuslee001 thanks for taking time to do this PR it really helps from a user perspective to keep things consistent.

Would it be possible to move the last two options in the drop-down filter to the top of the options list? So that these "Primary Members..." options are at the top.

[jusfreeman]

@seamuslee001 you might also want to fix the spelling mistake for this PR.

"Memebrship" is spelt "Membership" (but we all know what you mean)

Still pretty funny! :)

[seamuslee001]

ok @jusfreeman i have made both changes now would appreciate thoughts from others

[jusfreeman]

I agree with this primary mebership label chagne

;)

[yashodha]

@seamuslee001 It works as expected and the order is also fixed.

Can you please squash the commits so that I can merge?

[seamuslee001]

done @yashodha

[eileenmcnaughton]

Looks good to me - @yashodha I'll leave you to do a final check & merge

[agh1]

Awesome this looks great!

[yashodha]

@agh1 @jusfreeman @seamuslee001 great, merging this now.

[jusfreeman]

Thanks very much, everyone! I think this is a good step forward to improving the user experience, making CiviCRM easier to understand. @yashodha @seamuslee001 @eileenmcnaughton @MegaphoneJon @agh1

[jusfreeman]

FYI too for @jaapjansma

[eileenmcnaughton]

Yes - good collaboration