Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more uses of CRM_Core_DAO::$_nullArray that are unncessary #14564

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

Title says it all

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jun 17, 2019

(Standard links)

@civibot civibot bot added the master label Jun 17, 2019
@eileenmcnaughton
Copy link
Contributor

I looked through these to check the removed param really was optional. The regex function was the only one that didn't fit a pretty narrow pattern but that was only called from one place & neither the calling function nor the function defined it as returning by regex - so looks good to me

@eileenmcnaughton eileenmcnaughton merged commit 2555cc1 into civicrm:master Jun 17, 2019
@eileenmcnaughton eileenmcnaughton deleted the less_null_array branch June 17, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants