Remove unneeded use of CRM_Core_DAO::$_nullArray in executeQuery or s…

[seamuslee001]

…imilar calls

Overview

title says it all and why was this like it in the first place?

ping @eileenmcnaughton @monishdeb @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[colemanw]

why was this like it in the first place?

Allow me to demonstrate...
COPY. ✂️ PASTE. ♻️ REPEAT

why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?
why was this like it in the first place?

[eileenmcnaughton]

@mattwire - ^^ the technical explanation of the problem...

[eileenmcnaughton]

Actually there is another technical detail. On an unknown but now truly outdated version of php it was not possible to have a default parameter on variables passed by reference. They concurrently believed that passing by reference was more performant (@tttp debunked that around 2010)

[tttp]

Thanks @seamuslee001!

duh, not a bug per se, but it sure lasted a fair bit longer than needed ;)