[test] Call parent tearDown more consistently

[eileenmcnaughton]

Overview

Fix consistency on test teardown

Before

Less consistency on calling parent function

After

More consistency

Technical Details

Primarliy consistentcy - also supports checking nullArray is cleared per

#14550

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton

PHP Deprecated:  Non-static method CiviUnitTestCase::tearDown() should not be called statically in /home/jenkins/bknix-dfl/build/core-14552-3808w/sites/all/modules/civicrm/tests/phpunit/api/v3/ContributionPageTest.php on line 1657
PHP Stack trace:
PHP   1. {main}() /home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar:0
PHP   2. PHPUnit\TextUI\Command::main() /home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar:570
PHP   3. PHPUnit\TextUI\Command->run() phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/TextUI/Command.php:148
PHP   4. PHPUnit\TextUI\TestRunner->doRun() phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/TextUI/Command.php:195
PHP   5. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/TextUI/TestRunner.php:545
PHP   6. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/Framework/TestSuite.php:755
PHP   7. api_v3_ContributionPageTest::tearDownAfterClass() phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/Framework/TestSuite.php:760
PHP Fatal error:  Uncaught Error: Using $this when not in object context in /home/jenkins/bknix-dfl/build/core-14552-3808w/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:458
Stack trace:
#0 /home/jenkins/bknix-dfl/build/core-14552-3808w/sites/all/modules/civicrm/tests/phpunit/api/v3/ContributionPageTest.php(1657): CiviUnitTestCase::tearDown()
#1 phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/Framework/TestSuite.php(760): api_v3_ContributionPageTest::tearDownAfterClass()
#2 phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/Framework/TestSuite.php(755): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#3 phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/TextUI/TestRunner.php(545): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#4 phar:///home/jenkins/bknix-dfl/civicrm-buildkit/extern/phpunit6/phpunit6.phar/phpunit/TextUI/Command.php(195): PHPUnit\TextU in /home/jenkins/bknix-dfl/build/core-14552-3808w/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php on line 458

[seamuslee001]

@eileenmcnaughton test failures relate i think

[seamuslee001]

@eileenmcnaughton this needs to be

Suggested change

	parent::tearDown();
	$unitTest->teardown();