-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] add assert to ensure nullArray & nullObject are not contaminated #14543
Conversation
(Standard links)
|
Test fails also relate i think @eileenmcnaughton |
@@ -482,6 +482,8 @@ protected function tearDown() { | |||
|
|||
$this->cleanTempDirs(); | |||
$this->unsetExtensionSystem(); | |||
$this->assertEquals(NULL, CRM_Core_DAO::$_nullArray); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eileenmcnaughton i think this should be [] not NULL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seamuslee001 looks like jenkins does too :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets see what jenkins thinks now - kinda likely this won't pass
6aa9c0b
to
7964f61
Compare
added MOP as change makes sense to me |
Lol yeah -not counting on that pass though! |
Jenkins re test this please |
So the interesting thing is I would expect the first test to fail to fail in isolation too - but for me it doesn't... unless I got it wrong |
7964f61
to
eebff7f
Compare
ea39379
to
f16bb47
Compare
Using less different types of exceptions is cleaner- our own exception is pretty much our go-to so using here
f16bb47
to
1e0f58c
Compare
test this please |
2 similar comments
test this please |
test this please |
@seamuslee001 woot! |
Overview
Test fix to ensure the nullArray & nullObject are not being contaminated during test runs
Before
Less testing
After
More testing
Technical Details
After deep & excruciating pain I found an intermittent test fail was caused by contamination of these 'helpful helpers' - search & destroy similar cases
Comments