[TEST] Fix intermittent test fail on NULL array getting contaminated #14542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Test fails look related @eileenmcnaughton |
…ng later tests to pass the wrong thing
|
trying again |
|
This has passed and given it mainly affects tests i'm going to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a hard-to-diagnose test bug where certain combinations of tests don't pass due to variable contamination. This could cause bugs on live but we don't have any known cases
Before
CRM_Core_DAO::$_nullArray passed to profileCreate but in the test it is actually not null & causes a fail
After
empty var passed
Technical Details
This took a lot of bisecting to find :-(
Comments
Anything else you would like the reviewer to note