Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix A.net to resolve time when using default #14540

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes failure to resolve date in authorize.net - this is likely a test-only bug.

Before

In the unit test when it is run in isolation there is no receive_date in $_REQUEST so it uses the default of 'now' however this is not correctly handled

After

Default is formatted to a date string

Technical Details

This has been passing in our test suite -but in fact it seems that it only passes because some other test is contaminating the $_REQUES

Comments

This is presumably passed through to the contribution api & hence it is not so grumpy but when
passed to the activity create fn it is failing when the test is run in isolation (& maybe other scenarios?)
due to 'now' not being parsed correctly.

Presumably it is not left blank in production scenarios as this would have triggered bug reports since it is a clear bug

This is presumably passed through to the contribution api & hence it is not so grumpy but when
passed to the activity create fn it is failing when the test is run in isolation (& maybe other scenarios?)
due to 'now' not being parsed
@civibot
Copy link

civibot bot commented Jun 14, 2019

(Standard links)

@civibot civibot bot added the master label Jun 14, 2019
@seamuslee001
Copy link
Contributor

This seems to make sense merging

@seamuslee001 seamuslee001 merged commit 583a991 into civicrm:master Jun 14, 2019
@seamuslee001 seamuslee001 deleted the anettest branch June 14, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants