CiviDist fails on BSD flavor of 'cp' with '-r -p' switch to '-R -p'

[kcristiano]

Overview

civicrm/civicrm-buildkit#452

When building Joomla tarballs on OSX the build will fail on the alternate Joomla install zip generation.

Specifically this occurs at https://github.com/civicrm/civicrm-core/blob/master/distmaker/dists/joomla_php5.sh#L40

cp -r -p civicrm com_civicrm/admin/civicrm fails on the symlinked file vendor/pear/log/README.rst

Changing the command to cp -R -p civicrm com_civicrm/admin/civicrm allows both cividist and distmaker to complete successfully.

Before

cividist fails for joomla-alt om MacOSX

After

cividist will complete on all platforms.

Technical Details

Switch to GNU style option of '-R' that is supported on both GNU and BSD

Comments

There will need to be diligent testing on all platforms, MACOSX, linux, bknx after merge

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

You know I feel like generating joomla! tarballs is such an obscure use case. If the main tarballs fail to load @totten will quickly notice & fix. This one fails fast, fails hard & only fails for truly geeky people if it does fail so I'm prepared to merge a little bit flippantly on your research & testing

[kcristiano]

@totten as discussed post merge I did the following:

Built tarballs of master on BSD - success
Built tarballs of 5.14.0, 5.13.5 on BSD - failure as expected
Built tarballs of master on GNU(debian) - success
Built tarballs of 5.14.0, 5.13.5 on GNU(debian) - success

[totten]

Nice, so with this patch, master is working on both BSD+GNU. 👍