Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#965 Fix destination in payment edit #14518

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

colemanw
Copy link
Member

Overview

This is a reviewer's cut of #14362
When ajax popup forms are disabled, the form on "civicrm/payment/edit" shows a fatal error: "Expected one FinancialTrxn but found 25".

Before

"Expected one FinancialTrxn but found 25".

After

Redirects to contact edit form.

Comments

issue gitlab: https://lab.civicrm.org/dev/core/issues/965

@civibot
Copy link

civibot bot commented Jun 13, 2019

(Standard links)

@civibot civibot bot added the master label Jun 13, 2019
@seamuslee001 seamuslee001 merged commit f6d557f into civicrm:master Jun 13, 2019
@eileenmcnaughton eileenmcnaughton deleted the paymentEditFix branch June 13, 2019 21:14
@eileenmcnaughton
Copy link
Contributor

@agh1 @alifrumin can you make sure @CsarRamos is recognised in the release notes for this PR - it was Coleman's commit in the end but the concept work was by @CsarRamos (for a long-standing annoyance)

@alifrumin
Copy link
Contributor

@eileenmcnaughton certainly!

agh1 added a commit to agh1/civicrm-core that referenced this pull request Jul 10, 2019
elisseck pushed a commit to elisseck/civicrm-core that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants