Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] CRM_Case_BAO_Case::addcaseActivityLinks to CRM_Case_Selector_Search #14512

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Jun 13, 2019

Overview

This isolates the move of CRM_Case_BAO_Case::addcaseActivityLinks() out from the rest of #14349.

Before

The function is in CRM_Case_BAO_Case.

After

The function is in CRM_Case_Selector_Search.

Technical Details

Nothing within the function was changed except to change class names.

Comments

#14349 does a number of changes while also moving the function and @eileenmcnaughton suggested cutting this out as a refactor first.

@civibot
Copy link

civibot bot commented Jun 13, 2019

(Standard links)

@civibot civibot bot added the master label Jun 13, 2019
@yashodha
Copy link
Contributor

@agh1 looks good. Can be merged with no other usages of the method anywhere else.

@mattwire
Copy link
Contributor

Thanks @agh1

@mattwire mattwire merged commit 204a280 into civicrm:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants