Civi\Angular\ChangeSet - Relax debug-mode consistency check #14510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overview -------- The Angular subsystem *sometimes* includes a consistency-check. The consistency check ensures that an HTML document is read/written in consistency format (i.e. `encode(decode($html)) === $html`). However, the check is not often run, and it sometimes produces errors on consistency issues which we don't care about. This approach here is to relaxes the checks in `civicrm-core` and reproduce them in separate developer-oriented tooling. Before ------ * If an Angular HTML partial is not altered (`hook_civicrm_alterAngular`), then the partial is *not* checked for consistency. * If a site is in production/non-debug mode, then the partial is *not* checked for consistency. * If a site is in debug mode, then the partial *is* checked for consistency. After ----- * The partial is not checked for consistency. * A task is recorded on the [Afform roadmap](https://github.com/totten/afform/blob/master/docs/roadmap.md) to include better consistency checks in the `afform_auditor` extension.
|
(Standard links)
|
Sounds like the consistency check is inconsistent. Maybe it needs a consistency check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The Angular subsystem sometimes includes a consistency-check. The consistency check ensures that an HTML document is read/written in consistent format (i.e.
encode(decode($html)) === $html). However, the check is not often run, and it sometimes produces errors on consistency issues which we don't care about.The approach here is to relax the checks in
civicrm-coreand reproduce them in separate developer-oriented tooling.Before
hook_civicrm_alterAngular), then the partial is not checked for consistency.After
afform_auditorextension.