$this->_selectedTables is not populated incase of boleen filters #14503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
monishdeb
reviewed
Jun 13, 2019
| @@ -4300,7 +4300,8 @@ public function selectedTables() { | |||
| } | |||
| if (array_key_exists('filters', $table)) { | |||
| foreach ($table['filters'] as $filterName => $filter) { | |||
| if (!empty($this->_params["{$filterName}_value"]) | |||
| if ((isset($this->_params["{$filterName}_value"]) | |||
| && !CRM_Utils_System::isNull($this->_params["{$filterName}_value"])) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @monishdeb
Correct me if am wrong, CRM_Utils_Rule::boolean() checks for 0,1,Yes,No,True, False values but in my case the value can be any. I guess isNull would be better option.
Thoughts?
Pradeep
There was a problem hiding this comment.
Hmm right. Well, I have no issue with this change.
Happy to merge 👍
|
@pradpnayak @monishdeb I agree with this change - obviously there is a minor discussion around code style to resolve but the change makes sense |
|
I agree with this final patch and on quick run on local it safe to merge. Hence merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When you filter on report for boolean fields with option No then $this->_selectedTables is not populated.
Before
When you filter on report for boolean fields with option No then $this->_selectedTables is not populated.
After
When you filter on report for boolean fields with option No then $this->_selectedTables is populated.
Technical Details
Boolean filters use 1 or 0 values and !empty on 0 will return false. Hence used CRM_Utils_System::isNull() to check if its null or empty