Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF Extract override default currency function #14496

Merged

Conversation

mattwire
Copy link
Contributor

Overview

Simple extraction of duplicated code to a single shared function

Before

Same code duplicated

After

Same code in single function

Technical Details

There is an open question as to whether this code is actually required at all. But let's start by extracting it to one place.

Comments

@civibot civibot bot added the master label Jun 12, 2019
@civibot
Copy link

civibot bot commented Jun 12, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@mattwire sell jenkins on it & this is good to go. I went through the code changes line by line

@mattwire mattwire force-pushed the extract_overridedefaultcurrency branch from d13eac5 to 85939a7 Compare June 12, 2019 18:51
@seamuslee001 seamuslee001 merged commit d36119f into civicrm:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants