Improve I18n schema by including comments and default and NOT NULL or…

[seamuslee001]

… NULL statements to be more consistant with non lingual schema

Overview

This adds more information to the I18n schema structure so that when the translated schema is created it is more similar to the non multilingual schema

Before

New columns that are added may not have correct default or missing comments

After

More consistent schema

ping @mlutfy @pfigel @eileenmcnaughton thoughts?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mlutfy]

I agree on the concept, this would be a nice improvement.

I slightly worry on the duplication. We could run into issues where a description is changed in an XML schema file, but not updated in this i18n file. Probably an exception that does not happen often: some time ago, the interpretation of a field was reversed (is_something).

(not against merging, just raising the concern)

[seamuslee001]

@mlutfy i think that is the same issue as ensuring DAOs are regenerated etc (which btw this file gets generated when you generate the DAOs by ./bin/setup.sh -g or ./bin/regen.sh)

[eileenmcnaughton]

I think @seamuslee001 is correct - this is 'the same' as the main DAOS - merging based on otherwise positive feedback

[mlutfy]

Perfect, thank you!

[MegaphoneJon]

This seems to have caused a regression - it was caught earlier (translation#38, possible core#1800 as well) but isn't recent at this point, so I didn't tag #20753 as a regression.