Fix version for pledge message update, also remove 'please print' #14469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I added merge on pass as this is a reviewer's commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow up reviewer's commit on #14465
Before
Fixes the upgrade script to target the right version
After
Fixed, also removes the 'please print' line (@jusfreeman FYI - another one)
Technical Details
@philmb these are the things I was saying on the other PR - note if this doesn't get merged pretty soon the version will need to be changed again
Comments
@yashodha in doing this I also note an old version of the pledge_acknowledge_text & html in 4.5 upgrade files - do you think we can remove these now? Anyone upgrading to the latest version will eventually get this version & the don't need the intermediary do they?